-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Refactor goreleaser config generation for distributions #797
[chore] Refactor goreleaser config generation for distributions #797
Conversation
…tor-releases into fancy-approach-windows-build
@mowies I solved your last pending feedback and completed the release test in my fork. I tested releasing Currently running my fork-built Collector in I think this is looking good. Regarding the follow ups, I can and want to split this into multiple files organize it even better. I also plan to removed any unnecessaraly exported symbols and, last but not least, proceed with the work to add Windows container images. There are some nice adventures to come. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Let's only merge this after the release 0.119.0 goes out well... just for safety purposes. :D |
Also added the ppc64/power8 arch.
…a/opentelemetry-collector-releases into refactor-go-releaser-config
…tor-releases into refactor-go-releaser-config
nothing should have changed in terms of artifacts, so you should still have the same number of artifacts now |
@douglascamata did you already test your branch again? |
Agreed if you have a release branch in your fork to "prove your work" this otherwise looks great |
@mowies, @jackgopack4: I already started the release testing on my fork for this but couldn’t finish it yet. I’ll finish it tomorrow, tackle the comments and will post the results here when I’m done. 💪 |
…a/opentelemetry-collector-releases into refactor-go-releaser-config
I tested releasing v0.119.0 (see https://github.com/douglascamata/opentelemetry-collector-releases/tags.). The release is available at https://github.com/douglascamata/opentelemetry-collector-releases/releases/tag/v0.119.0. The amount of artifacts produced by my fork's release matches the official's (452 in total) and I've been running the released images from Docker Hub account in kind without any issues. I think we are good to go. |
@jpkrohling pinging you as you are doing the release on Monday, merging this since it looks good |
thank you, @mx-psi |
@mx-psi @jpkrohling I’ll be available to help with the release in case something goes wrong. Just ping me on CNCF slack. 💪 |
This PR will split off of #795.
This moves the code for generating the
goreleaser
configuration for the distros into a more declarative and easy-to-extend form.Why so many changes? 😱
I am completely aware that it represents a big rewrite of this part of code. I tried a few different approaches with the intent of having a minimum change that would allow me to support Windows, but the amount of changes needed always ended up snowballing quickly. Some examples of the reasons for this "snowballing" of code are (non-exhaustive list):
This might not the best code for this job too, but at least I believe it sets up a good structure that we can build upon and iterate on to improve.
I'm very open to hear your feedback and see how we can move this forward!
I can join the Collector SIG call on 2025-01-15 to talk about this if any maintainer finds it more productive.
Questions ⍰
If anyone, please, could help me out in testing that release process works fine with the update goreleaser configuration, it would be aaaaamazing! I don't feel super confident without testing this, of course.