-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/k8sattributes] Add support for profiles signal #35999
base: main
Are you sure you want to change the base?
[processor/k8sattributes] Add support for profiles signal #35999
Conversation
f4a8b82
to
70404bc
Compare
0b7efee
to
00ff5b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but I would like to do the update-otel separately, so all core modules point to the same commit
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we cover profiles in the e2e testing as well? See https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.112.0/processor/k8sattributesprocessor/e2e_test.go. Either tuning the existing tests or introducing a new one.
I have updated the e2e test. However, the |
78c7c27
to
faef628
Compare
I have opened an issue (#36127) to track it and skip the tests with added |
Description
Add support for profiles signal to
k8sattributesprocessor
.Link to tracking issue
Fixes #35983
Testing