Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/netflow] Add the netflow receiver - PR 1 #34164
base: main
Are you sure you want to change the base?
[receiver/netflow] Add the netflow receiver - PR 1 #34164
Changes from 12 commits
e4b5115
be502c2
3ae8ad1
9aa77b6
b619e40
5f03ff9
040136f
c4e9bd2
8de9251
cf4720b
c5ee961
b9f74cf
0996c1c
97e1bec
77270e6
8c7bd24
d446489
7561af8
871f2ff
f8d4c2c
5cea6ec
d6dae6e
3b42bc4
306b267
3b1019e
7e13976
062d07a
f62e092
ca5128c
8c65324
56b1024
f3e45ed
9680294
cd49448
e1c03bf
20eee81
f56b4ae
4428150
0ff2e6c
e6b99ac
58b4baa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I configure multiple netflow listeners, or is it one listener per scheme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but now that you mention it I think it might make more sense to allow a single listener per netflow config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider supporting the auto-detect feature of goflow2 vs making users explicitly set what flow type they are using.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the queue size here is # of UDP Packets, a UDP packet can be up to 9KB which would be 9GB of memory usage with a full queue.
Perhaps the default queue should be smaller?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's a good default? Should we make this
1_000
so it is only 9MB?