-
Notifications
You must be signed in to change notification settings - Fork 79
Update README structure and content #1385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b3c4bb9 to
f646b89
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1385 +/- ##
=======================================
Coverage 63.30% 63.30%
=======================================
Files 158 158
Lines 3109 3109
Branches 320 320
=======================================
Hits 1968 1968
Misses 1046 1046
Partials 95 95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| //... | ||
| api(platform("io.opentelemetry.android:opentelemetry-android-bom:0.16.0-alpha")) | ||
| implementation("io.opentelemetry.android:android-agent") // Version is resolved thru bom | ||
| api(platform("io.opentelemetry.android:opentelemetry-android-bom:<version>")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have build automation that runs as part of the release process that updates these...so we want to keep the latest specific version here. It will be automatically updated.
| api(platform("io.opentelemetry.android:opentelemetry-android-bom:<version>")) | |
| api(platform("io.opentelemetry.android:opentelemetry-android-bom:0.16.0-alpha")) |
(This allows folks to easily copy/paste a working example with the latest version).
breedx-splk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I had one small fix to merge about the version number, but overall this is a nice change.
LikeTheSalad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers!
Update baseline README before adding usage example