Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor load balance #424

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Refactor load balance #424

merged 5 commits into from
Jun 14, 2024

Conversation

L-M-Sherlock
Copy link
Member

I try to make the code more clear and efficient. @user1823, could you review this PR?

@L-M-Sherlock L-M-Sherlock added the enhancement New feature or request label Jun 14, 2024
@user1823
Copy link
Contributor

This refactored code is much easier to understand. Thanks.

I suggest renaming some of the variables:

  1. self.due_cnt_perday_from_first_dayself.due_cnt_per_day ("from first day" is not needed IMO)
  2. self.backlogself.due_today
  3. self.learned_cnt_todayself.reviewed_today

@L-M-Sherlock L-M-Sherlock merged commit 0d51871 into main Jun 14, 2024
2 checks passed
@L-M-Sherlock L-M-Sherlock deleted the Refactor-load-balance branch June 14, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants