-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add @mrcentimetre as a contributor #381
feat: add @mrcentimetre as a contributor #381
Conversation
Congratulations on completing the How to Contribute to Open Source chapter of the Intro to Open Source Course with your contribution to this repository, @mrcentimetre! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in the next chapter and share it with us! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
Hey @mrcentimetre, this looks great! We've merged in some new PRs since you submitted. Can you merge the latest changes and resolve conflicts? If you need some help with that, check out this post: Keeping Your Branch Up to Date and Handling Merge Conflicts While Waiting for PR Reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in response. Did you run npm contributors generate? There are some breaking changes here with closing a bracket in the .all-contributors
and the shield in the readme that has the contributor counter isn't updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mrcentimetre,
We have merged some PRs before yours. Please resolve the conflicts before we can further review your PR.
Please let me know if you need any help. Thanks. 😊
@mrcentimetre you need to run the command to generate your profile after resolving the conflicts. I don't see the shield increase here. Please read the resolving conflicts section carefully. Thank you. |
Description
This PR adds @mrcentimetre as a contributor.
What type of PR is this? (check all applicable)
Related Issues
Closes #380
Contributors Checklist
I've read through the Getting Started section.
Have you run
npm run contributors:generate
to generate your profile and the badge on the README?Added to documentation?
Screenshot (Required for PR Review)
[optional] What GIF best describes this PR or how it makes you feel?