Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @franklinjpt as a contributor #375

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

franklinjpt
Copy link
Contributor

@franklinjpt franklinjpt commented Jul 6, 2024

Description

This PR adds @franklinjpt as a contributor.

What type of PR is this? (check all applicable)

  • 🤝 Add a contributor
  • 📝 Documentation Update

Related Issues

Closes #374

Contributors Checklist

I've read through the Getting Started section.

  • ✅ Yes
  • ❌ Not yet

Have you run npm run contributors:generate to generate your profile and the badge on the README?

  • ✅ Yes
  • ❌ No

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Screenshot (Required for PR Review)

open-sauced-profile.jpg

[optional] What GIF best describes this PR or how it makes you feel?

excited

@franklinjpt franklinjpt requested a review from a team as a code owner July 6, 2024 01:25
Copy link

github-actions bot commented Jul 6, 2024

Congratulations on completing the How to Contribute to Open Source chapter of the Intro to Open Source Course with your contribution to this repository, @franklinjpt! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in the next chapter and share it with us!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @franklinjpt,

Thank you for your contribution! ✨

You have failed checks that you need to address before we can review your PR. Please fix each of them until all checks pass.

You also need to provide the description of your PR in the "Description" section of your PR template.

Let me know once you've fixed them, or if you have questions or need help.

Thank you. 🙂

@franklinjpt
Copy link
Contributor Author

franklinjpt commented Jul 6, 2024

Hey @franklinjpt,

Thank you for your contribution! ✨

You have failed checks that you need to address before we can review your PR. Please fix each of them until all checks pass.

You also need to provide the description of your PR in the "Description" section of your PR template.

Let me know once you've fixed them, or if you have questions or need help.

Thank you. 🙂

Hi @adiati98 I already made the changes. Is there something else I should do let me know.

Thank you

@BekahHW
Copy link
Member

BekahHW commented Jul 17, 2024

@franklinjpt thanks for your Pull Request! We've merged in some new PRs since you submitted. Can you merge the latest changes and resolve conflicts? If you need some help with that, check out this post: Keeping Your Branch Up to Date and Handling Merge Conflicts While Waiting for PR Reviews.

@adiati98
Copy link
Member

adiati98 commented Oct 7, 2024

Well done and thank you for your contribution, @franklinjpt! ✨

If you haven't, you can join our Community.
Also, check out our pizza-verse repo if you want to contribute further! 🍕🍴

git merge GIF

@adiati98 adiati98 merged commit a12fa41 into open-sauced:main Oct 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: add @franklinjpt as a contributor
3 participants