database: switch to per-driver setup for plain sql PG/MySQL #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparation for #199. Signed-off-by: Stephan Renatus <[email protected]>
srenatus
force-pushed
the
sr/uokvxopnqqol
branch
5 times, most recently
from
2e91765 to
612ab3c
Compare
Fixes #199 Signed-off-by: Stephan Renatus <[email protected]>
srenatus
force-pushed
the
sr/uokvxopnqqol
branch
10 times, most recently
from
dfc897b to
bc37c88
Compare
Signed-off-by: Stephan Renatus <[email protected]>
This would be too confusing: you'd be able to update the secret in the database, via the HTTP API, but it would not have an effect, since the credentials used for the database are only consumed on service startup. Signed-off-by: Stephan Renatus <[email protected]>
srenatus
force-pushed
the
sr/uokvxopnqqol
branch
from
bc37c88 to
8cf6628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for #199.