[Feature] add XFUND dataset and project LayoutLMv3#1809
Open
KevinNuNu wants to merge 58 commits intoopen-mmlab:dev-1.xfrom
Open
[Feature] add XFUND dataset and project LayoutLMv3#1809KevinNuNu wants to merge 58 commits intoopen-mmlab:dev-1.xfrom
KevinNuNu wants to merge 58 commits intoopen-mmlab:dev-1.xfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 97 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
…v3ImageProcessor实现数值对齐
KevinNuNu
changed the title
Collaborator
|
good job~ |
gaotongxiao
reviewed
Jun 23, 2023
Collaborator
gaotongxiao
left a comment
gaotongxiao
left a comment
There was a problem hiding this comment.
Overall a great project! It can be merged as two comments are resolved
| for f in glob.glob(src): | ||
| if not osp.exists( | ||
| osp.join(dst, osp.relpath(f, self.data_root))): | ||
| if not osp.exists(osp.join(dst, osp.basename(f))): |
Collaborator
There was a problem hiding this comment.
This modification may break other dataset preparers. Need to make the if condition compatible with both cases.
Collaborator
There was a problem hiding this comment.
A readme is very important to tell others how to run your project, you can spend some time writing it
gaotongxiao
approved these changes
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
1.增加xfund SER/RE任务的数据集：支持生成MMOCR形式的SER、RE任务标注文件(以.json结尾)
2.新增LayoutLMv3 project.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: