Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add XFUND dataset and project LayoutLMv3 #1809

Open
wants to merge 58 commits into
base: dev-1.x
Choose a base branch
from

Conversation

KevinNuNu
Copy link
Contributor

@KevinNuNu KevinNuNu commented Mar 25, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

1.增加xfund SER/RE任务的数据集:支持生成MMOCR形式的SER、RE任务标注文件(以.json结尾)
2.新增LayoutLMv3 project.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 97 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@KevinNuNu KevinNuNu changed the title [Feature] add XFUND dataset [Feature] add XFUND dataset and project LayoutLMv3 May 1, 2023
@vansin vansin assigned gaotongxiao and unassigned Harold-lkk May 1, 2023
@vansin
Copy link
Collaborator

vansin commented May 5, 2023

good job~

Copy link
Collaborator

@gaotongxiao gaotongxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a great project! It can be merged as two comments are resolved

@@ -186,8 +186,7 @@ def move(self, mapping: List[Tuple[str, str]]) -> None:
if '*' in src:
mkdir_or_exist(dst)
for f in glob.glob(src):
if not osp.exists(
osp.join(dst, osp.relpath(f, self.data_root))):
if not osp.exists(osp.join(dst, osp.basename(f))):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This modification may break other dataset preparers. Need to make the if condition compatible with both cases.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A readme is very important to tell others how to run your project, you can spend some time writing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants