Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Debug converters #143

Merged
merged 9 commits into from
Apr 1, 2022
Merged

[Fix] Debug converters #143

merged 9 commits into from
Apr 1, 2022

Conversation

pangyyyyy
Copy link
Collaborator

@pangyyyyy pangyyyyy commented Mar 30, 2022 •
edited by caizhongang
Loading

Resolves #124; resolves #135; and partially #141

Changes:

  • Fix left-right flipping of keypoints and SMPL pose in SURREAL dataset
  • Fix incorrect global orient in AGORA preprocessing
  • Edit documentation for extracting images before training (H36m and MPI-INF-3DHP)
  • Fix wrong mosh path for H36m SPIN preprocessing
  • Removing conflicting prefix for MPI-INF-3DHP images for normal and SPIN preprocessing
  • Add download link of MPII train.h5

@pangyyyyy pangyyyyy changed the title Debug converters [Fix] Debug converters Mar 30, 2022
@pangyyyyy pangyyyyy mentioned this pull request Mar 30, 2022
Open
@caizhongang caizhongang self-assigned this Mar 30, 2022
@codecov
Copy link

codecov bot commented Mar 30, 2022 •
edited
Loading

Codecov Report

Merging #143 (e7508ad) into main (96517ae) will increase coverage by 0.09%.
The diff coverage is 90.55%.

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   84.95%   85.04%   +0.09%     
==========================================
  Files         169      169              
  Lines       13515    13718     +203     
==========================================
+ Hits        11482    11667     +185     
- Misses       2033     2051      +18
Flag Coverage Δ
unittests 85.04% <90.55%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmhuman3d/data/data_converters/mpi_inf_3dhp.py 86.50% <0.00%> (ø)
mmhuman3d/data/data_converters/agora.py 88.10% <75.55%> (-3.45%) ⬇️
mmhuman3d/data/data_converters/surreal.py 90.14% <100.00%> (+0.35%) ⬆️
mmhuman3d/data/data_structures/human_data.py 99.23% <100.00%> (+1.81%) ⬆️
...e/visualization/renderer/torch3d_renderer/utils.py 70.96% <0.00%> (-3.23%) ⬇️
mmhuman3d/models/registrants/smplify.py 90.52% <0.00%> (-3.10%) ⬇️
.../visualization/renderer/torch3d_renderer/meshes.py 86.99% <0.00%> (-0.87%) ⬇️
mmhuman3d/utils/mesh_utils.py 91.00% <0.00%> (ø)
mmhuman3d/models/losses/__init__.py 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e21e38...e7508ad. Read the comment docs.

caizhongang
caizhongang reviewed Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@caizhongang caizhongang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the PR is quite ready except for a few minor imperfections.

mmhuman3d/data/data_converters/agora.py Show resolved Hide resolved
mmhuman3d/data/data_converters/surreal.py Show resolved Hide resolved
@caizhongang
Copy link
Collaborator

caizhongang commented Mar 31, 2022 •
edited
Loading

In #135 and #141 , our user mentioned that

MPII official dataset missing train.h5, see #135

train.h5 is actually from here

Annotations for the training set of the MPII human pose dataset. Recovered from the Stacked Hourglass repo.

Would you mind adding this into the PR and link #135 also?

@caizhongang caizhongang mentioned this pull request Mar 31, 2022
Closed
@caizhongang caizhongang self-requested a review March 31, 2022 13:32
@caizhongang caizhongang merged commit 4cbffc4 into open-mmlab:main Apr 1, 2022
ttxskk pushed a commit that referenced this pull request Jun 17, 2022
@pangyyyyy
[Fix] Debug converters (#143)
b683420 
- Fix left-right flipping of keypoints and SMPL pose in SURREAL dataset 
- Fix incorrect global orient in AGORA preprocessing
- Edit documentation for extracting images before training (H36m and MPI-INF-3DHP)
- Fix wrong mosh path for H36m SPIN preprocessing
- Removing conflicting prefix for MPI-INF-3DHP images for normal and SPIN preprocessing
- Add download link of MPII `train.h5`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caizhongang caizhongang caizhongang approved these changes

Assignees

@caizhongang caizhongang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

convert agora data and visual smpl is wrong? Can not access train.h5 from MPII official site.
2 participants
@pangyyyyy @caizhongang