New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MaskGCT env setup and notebook #316

Merged

yuantuo666 merged 2 commits into open-mmlab:main from yuantuo666:main

Oct 31, 2024

Collaborator

yuantuo666 commented Oct 31, 2024 •

edited

Loading

✨ Description

Update MaskGCT env setup and notebook codes.

🚧 Related Issues

#314
#302
#299
#298
#297

👨‍💻 Changes Proposed

Change from env.sh to requirements.txt: support Windows platform.
Adapt Jupyter Notebook: adding directory change code, more generating examples.

🧑‍🤝‍🧑 Who Can Review?

@HeCheng0625 @RMSnow

🛠 TODO

None

✅ Checklist

Code has been reviewed
Code complies with the project's code standards and best practices
Code has passed all tests
Code does not affect the normal use of existing features
Code has been commented properly
Documentation has been updated (if applicable)
Demo/checkpoint has been attached (if applicable)


          Update MaskGCT env setup and notebook

bc735d7

yuantuo666 requested review from HeCheng0625 and RMSnow

October 31, 2024 09:18


          Update README.md

bef5958

Collaborator Author

yuantuo666 commented Oct 31, 2024

Is it necessary to include the inference.py code in the README file?

It makes the README file lengthy: https://github.com/yuantuo666/Amphion/blob/bef59584c58b3a369cea9b99267e3789bb0d17cc/models/tts/maskgct/README.md#start-from-scratch

HeCheng0625 approved these changes

View reviewed changes

Collaborator

HeCheng0625 left a comment

LGTM!

yuantuo666 merged commit 2940c43 into open-mmlab:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet