Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese version #81

Closed
wants to merge 1 commit into from
Closed

Conversation

louie007
Copy link

Add Chinese version of home & community pages.
All translation texts have been reviewed carefully, in order to be ready for the upcoming official release of v1.0.
Please add a dropdown menu item to facilitate switching languages if necessary, thanks!

@Sachin-chaurasiya
Copy link
Member

Sachin-chaurasiya commented May 2, 2023

Hello @louie007, Thanks for Opening a PR, however currently we don't have version support and we are planning to move from vanilla js to ReactJS then we will add support for a different language because, with the current codebase, it will be difficult to manage the language support.

Would be great if you discuss these things before opening the PR so that maintainers can provide the feedback.

@louie007
Copy link
Author

louie007 commented May 2, 2023

Hello @louie007, Thanks for Opening a PR, however currently we don't have version support and we are planning to move from vanilla js to ReactJS then we will add support for a different language because, with the current codebase, it will be difficult to manage the language support.

Would be great if you discuss these things before opening the PR so that maintainers can provide the feedback.

Hi Sachin, I had a discussion with Harsha on Slack last week. When we looked at the source code, yes, maybe a React version will be much better to support multi-languages website. Please let me know when the new React version is ready ;-)

@Sachin-chaurasiya
Copy link
Member

Hello @louie007, Thanks for Opening a PR, however currently we don't have version support and we are planning to move from vanilla js to ReactJS then we will add support for a different language because, with the current codebase, it will be difficult to manage the language support.
Would be great if you discuss these things before opening the PR so that maintainers can provide the feedback.

Hi Sachin, I had a discussion with Harsha on Slack last week. When we looked at the source code, yes, maybe a React version will be much better to support multi-languages website. Please let me know when the new React version is ready ;-)

Sure @louie007, will let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants