Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#19932: fix the default pageSize setting on Ingestions Page #19939

Merged
merged 4 commits into from
Feb 24, 2025
Merged

#19932: fix the default pageSize setting on Ingestions Page #19939

merged 4 commits into from
Feb 24, 2025

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Feb 24, 2025 •
edited
Loading

Describe your changes:

Issue : #19932

  • I worked on fixing the default page size for the Ingestion Page, which was 10 to 15 as the Size changer dropdown.
  • Also added support to persist the pagination on browser back

Issue :
image

Resolved :
image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Feb 24, 2025
@Ashish8689 Ashish8689 self-assigned this Feb 24, 2025
@Ashish8689 Ashish8689 requested a review from a team as a code owner February 24, 2025 10:47
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Feb 24, 2025
@Ashish8689 Ashish8689 added the To release Will cherry-pick this PR into the release branch label Feb 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.74% (41463/64043) 41.1% (16766/40791) 44.37% (5059/11402)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Ashish8689 Ashish8689 merged commit 2257f02 into main Feb 24, 2025
14 of 17 checks passed
@Ashish8689 Ashish8689 deleted the fix-ingestion-page-size branch February 24, 2025 14:15
@github-actions GitHub Actions
Copy link
Contributor

Changes have been cherry-picked to the 1.6.5 branch.

github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
@Ashish8689
#19932: fix the default pageSize setting on Ingestions Page (#19939)
17ae9a4 
* fix the default pageSize setting on Ingestions Page

* minor change

* added playwright for it

* fix minor misplacement

(cherry picked from commit 2257f02)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ashish8689 @chirag-madlani