Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mylife: smoother myhealth dark mode (fixes #4598) #4627

Merged
merged 9 commits into from
Oct 15, 2024
Merged

Conversation

deeppp15
Copy link
Member

Description

Changes

  • Moved xml spinner assignment to adapter spinner assignment

Screenshot

image

@Kuljeet1998
Copy link
Contributor

Suggestion: Instead of hint texts being white, we can make it grey for better UI.

@deeppp15
Copy link
Member Author

Hi @Kuljeet1998 , that's a great idea!

I have added the changes below,

image

Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Kuljeet the hints would be better if are greyish

@Okuro3499 Okuro3499 dismissed their stale review October 14, 2024 19:43

updates came in before this review

@dogi dogi changed the title dashboard: smoother myHealth darkmode (fixes #4598) mylife: smoother myhealth dark mode (fixes #4598) Oct 15, 2024
@dogi dogi merged commit 0013b44 into master Oct 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

myHealth: update health record not darkmode compatible
4 participants