bugfix: element_solid_strain and i_solid_vars #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codie3611
approved these changes
Sep 24, 2024
|
Unfortunately I cannot merge as I do not have write access.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix issue #63
The i_solid_vars already contains the element_solid_history_variables therefore it is wrong to increment it again. The solid true strain data (element_solid_plastic_strain_tensor, element_solid_thermal_strain_tensor and element_solid_strain) are contained in element_solid_history_variables, if present. When element_solid_strain is requested, it is at the end of solid element data, therefore also at the end of element_solid_history_variables. The element_solid_history_variables are composed of strain data in the following order: [element_solid_plastic_strain_tensor], [element_solid_thermal_strain_tensor], [element_solid_strain].