-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version requirements #56
Update version requirements #56
Conversation
Did you update the lock file or regenerate it? Usually regenerating makes less trouble. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are fine. Thanks. Now you just need to make CI happy.
Flake8 seems dead and doesn't work with newer python libraries, so I replaced it with ruff. Formatting is still done by black (otherwise the diff would be gigantic), but in the future formatting too could be done by ruff. PS: in |
We can also transition to ruff in another PR for formatting. |
Yep, I don't plan in adding anything to this PR, it's good as-is ! (just in case you're not aware, only you can merge, I don't have the rights, and it's the same for #57) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge then
Fixes #55
This:
Note: lint CI action will likely not pass as I updated
black
but did not run it (to keep the diff small)