Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version requirements #56

Merged

Conversation

awoimbee
Copy link
Contributor

@awoimbee awoimbee commented Apr 11, 2024

Fixes #55

This:

  • upgrades dependencies
  • change python version requirements (py38 is near EOL, unsupported by pandas, and py312 is stable)

Note: lint CI action will likely not pass as I updated black but did not run it (to keep the diff small)

@codie3611
Copy link
Contributor

Did you update the lock file or regenerate it? Usually regenerating makes less trouble.

Copy link
Contributor

@codie3611 codie3611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are fine. Thanks. Now you just need to make CI happy.

@awoimbee
Copy link
Contributor Author

awoimbee commented Apr 15, 2024

Flake8 seems dead and doesn't work with newer python libraries, so I replaced it with ruff. Formatting is still done by black (otherwise the diff would be gigantic), but in the future formatting too could be done by ruff.

PS: in femzip_mapper.py I removed duplicateed dict keys (to make ruff happy)

@codie3611 codie3611 self-requested a review April 15, 2024 09:24
@codie3611
Copy link
Contributor

We can also transition to ruff in another PR for formatting.

@awoimbee
Copy link
Contributor Author

We can also transition to ruff in another PR for formatting.

Yep, I don't plan in adding anything to this PR, it's good as-is !

(just in case you're not aware, only you can merge, I don't have the rights, and it's the same for #57)

Copy link
Contributor

@codie3611 codie3611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge then

@awoimbee
Copy link
Contributor Author

Feel free to merge then

I can't, I don't have the rights to this repo
Screenshot from 2024-04-15 14-57-25

@codie3611 codie3611 merged commit aacb322 into open-lasso-python:develop Apr 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support python 3.12 (and 3.13, and future versions)
2 participants