Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken link fix #799

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

broken link fix #799

wants to merge 1 commit into from

Conversation

eslerm
Copy link

@eslerm eslerm commented Mar 20, 2022

No description provided.

Copy link
Contributor

@darigovresearch darigovresearch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @eslerm thanks for taking the time to make the pull request, can confirm that there is a broken link and this merge request would resolve the problem.

Does anyone with merge rights require any other changes for the pull request to be merged?

@eslerm
Copy link
Author

eslerm commented Aug 13, 2022

Hi @darigovresearch

Can you check https://github.com/open-guides/og-aws/pull/799/files? Line 1814 needs to be joined with line 1815 with the domain name added.

Looks like this on the readme currently: https://github.com/open-guides/og-aws#cloudformation-alternatives-and-lock-in

@darigovresearch
Copy link
Contributor

@eslerm you can update your pull request to make the update you want, you can do that by clicking on the three dots then Edit file on the Files changed tab. Maybe it would be best to do an indented bullet point rather than merging the two into a bullet point like on line 1795.

image

Could you also clarify what you mean by ... with the domain name added?

All URLs in your changes appear to work and have their domains

@eslerm
Copy link
Author

eslerm commented Aug 13, 2022

The original patch is as intended.

I will wait for projects maintainers to review.

@darigovresearch
Copy link
Contributor

@eslerm sounds good.

Do any maintainers require anything else for this pull request to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants