Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement gherkin tests #1363

Merged

Conversation

chrfwow
Copy link
Contributor

@chrfwow chrfwow commented Mar 6, 2025

This PR

Implements the recently added gherkin tests

Related Issues

Part of open-feature/flagd-testbed#13

chrfwow added 2 commits March 6, 2025 09:16
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.25%. Comparing base (959e675) to head (6ee3f85).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1363      +/-   ##
============================================
+ Coverage     92.80%   93.25%   +0.45%     
- Complexity      466      470       +4     
============================================
  Files            43       43              
  Lines          1125     1126       +1     
  Branches         90       90              
============================================
+ Hits           1044     1050       +6     
+ Misses           53       48       -5     
  Partials         28       28              
Flag Coverage Δ
unittests 93.25% <100.00%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chrfwow chrfwow marked this pull request as ready for review March 6, 2025 09:20
@chrfwow chrfwow requested a review from a team as a code owner March 6, 2025 09:20
Signed-off-by: christian.lutnik <[email protected]>
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very pretty. No notes.

@toddbaert toddbaert requested a review from aepfli March 6, 2025 22:20
Copy link

sonarqubecloud bot commented Mar 7, 2025

@chrfwow chrfwow merged commit c37d249 into open-feature:main Mar 7, 2025
12 checks passed
@chrfwow chrfwow deleted the implement-context-mergin-gherkin-tests branch March 7, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants