Skip to content

feat: ofrep provider #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: ofrep provider #1429

wants to merge 8 commits into from

Conversation

Rahul-Baradol
Copy link

@Rahul-Baradol Rahul-Baradol commented Jun 18, 2025 •
edited
Loading

This PR

  • Adds OFREP provider

Related Issues

Fixes #1413

Follow-up Tasks

  • Dev testing
  • Added tests
  • Docs

@Rahul-Baradol Rahul-Baradol requested a review from a team as a code owner June 18, 2025 11:31
liran2000
liran2000 reviewed Jun 19, 2025
View reviewed changes
Copy link
Member

@liran2000 liran2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this 😃 added some comments

@liran2000 liran2000 requested a review from thomaspoignant June 19, 2025 12:41
@Rahul-Baradol Rahul-Baradol force-pushed the ofrep-provider branch 4 times, most recently from bae4f4f to 5ea2826 Compare June 20, 2025 11:48
@Rahul-Baradol
feat: ofrep provider
c18d670 
Signed-off-by: Rahul Baradol <[email protected]>
liran2000
liran2000 reviewed Jun 21, 2025
View reviewed changes
@Rahul-Baradol Rahul-Baradol requested a review from liran2000 June 22, 2025 12:12
liran2000
liran2000 approved these changes Jun 22, 2025
View reviewed changes
Copy link
Member

@liran2000 liran2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the review comments were addressed, thanks.
Added some more review comments on last commits, approving, can wait for others to review as well.

aepfli
aepfli approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you this looks good to me. I am just questioning if we should maybe more often use the @Value lombok annotation to generate record like objects. I think this could reduce some of the boilderplate even more here. Thank you

@thomaspoignant thomaspoignant mentioned this pull request Jun 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrfwow chrfwow chrfwow left review comments

@aepfli aepfli aepfli approved these changes

@liran2000 liran2000 liran2000 approved these changes

@beeme1mr beeme1mr Awaiting requested review from beeme1mr

@toddbaert toddbaert Awaiting requested review from toddbaert

@lukas-reining lukas-reining Awaiting requested review from lukas-reining

@thomaspoignant thomaspoignant Awaiting requested review from thomaspoignant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Create OFREP provider
4 participants
@Rahul-Baradol @aepfli @chrfwow @liran2000