Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add providerId as a configuration option #1567

Merged
merged 4 commits into from
Mar 27, 2025
Merged

Conversation

beeme1mr
Copy link
Member

@beeme1mr beeme1mr commented Feb 18, 2025

This PR

  • adds providerId as a valid configuration option

Related Issues

Relates to open-feature/go-sdk-contrib#626

Notes

provider_id is supported in sync request proto. This change specifics how the properties could be set in the provider.

Follow-up Tasks

Update test bed config.feature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Michael Beemer <[email protected]>
@beeme1mr beeme1mr requested a review from a team as a code owner February 18, 2025 19:02
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 18, 2025
@beeme1mr beeme1mr requested review from aepfli and chrfwow February 18, 2025 19:02
Copy link

netlify bot commented Feb 18, 2025

Deploy Preview for polite-licorice-3db33c canceled.

Name Link
🔨 Latest commit 03d2ebb
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/67e3d5e348520f0008f39ced

@beeme1mr beeme1mr requested a review from toddbaert February 18, 2025 19:02
@beeme1mr beeme1mr requested a review from cupofcat March 10, 2025 17:37
Signed-off-by: Michael Beemer <[email protected]>
@beeme1mr beeme1mr changed the title docs: add providerID as a configuration option docs: add providerId as a configuration option Mar 11, 2025
beeme1mr and others added 2 commits March 18, 2025 16:24
aepfli added a commit to open-feature/flagd-testbed that referenced this pull request Mar 26, 2025
relates: open-feature/flagd#1567
Signed-off-by: Simon Schrottner <[email protected]>
aepfli added a commit to open-feature/flagd-testbed that referenced this pull request Mar 26, 2025
relates: open-feature/flagd#1567
Signed-off-by: Simon Schrottner <[email protected]>
aepfli added a commit to open-feature/flagd-testbed that referenced this pull request Mar 26, 2025
relates: open-feature/flagd#1567
Signed-off-by: Simon Schrottner <[email protected]>
@beeme1mr beeme1mr merged commit ddfa020 into main Mar 27, 2025
10 checks passed
@beeme1mr beeme1mr deleted the add-provider-id branch March 27, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants