Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flipt provider - remove unused parameters in tests #296

Closed
wants to merge 51 commits into from
Closed

fix: flipt provider - remove unused parameters in tests #296

wants to merge 51 commits into from

Conversation

jeandreidc
Copy link
Contributor

This PR

  • cleans unused theory params
  • Utilized defined params in the test

Related Issues

Fixes #295

@jeandreidc
Initial working commit without tests
97a5970 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
FliptProvider: Handle type mismatch and Value casting
c707b3e 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
FliptProvider: Added extension to map flipt context to openFeature, a…
ee902c6 
…dded handling of http exceptions thrown by flipt client

Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Added xmldoc on extension function
656711b 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Added handling of different Value types, added tests to check for pro…
f17949b 
…per serialization to Dict<string, string>

Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Added handling of array of Values, introduced universal deserializer …
7898c86 
…JSON settings

Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Added support to serialize nested Values list
41cf5bf 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
FliptProvider: Add support for serializing structure
d94a6c6 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
FliptProvider: Implement Structure deserializer
d651b3c 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
FliptProvider: Rename ClientWrapper to converter
77afc27 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
FliptProvider: Implemented wrapper class, added unit tests
a9ca17f 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
FliptProvider: Code cleanup
d98f9ce 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
FliptProvider: Extracted Converter tests to its own file
48c555c 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Added unit tests for FliptToOpenFeature converter for variants and bo…
d4b3e42 
…oleans

Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Added FliptToOpenFeatureConverter tests for non-existent flags for Va…
10b1d86 
…riant types

Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Update release metadata
d8d382d 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Replaced Flipt package with a generated RestClient from their openapi…
204144f 
…spec

Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Changed exception handling to use generated exceptions by nswag
563dd5f 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Modified unit test to throw mocked FliptExceptions
29077ea 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Utilized OpenFeature Reason type on Resolutions
e11bdaa 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Change test project setting; Cleaned FLiptConverter code
cd1b5a9 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Change types to support all .net target versions
83d0fde 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
FliptProvider: Update Readme
2417a9a 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
FliptProvider: Update ReadMe, test fliptClientWrapper calls
fd7210a 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
FliptProvider: Removed wrong code change in a different project
328c5a1 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
lint
0dcca7e 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Used HttpStatusCode.Ambiguous because TooManyRequests is not yet impl…
cc8a209 
…emented in .net 4.6

Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
FliptProvider: Updated openapi.yaml src, regenerated RestClient using…
c3d28b8 
… new openapi spec, removed typos in readme, unit test updates

Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Update readme instructions
6633132 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
reverted nuget.config changes, fix linting spacing issue caused by fo…
d8c4e85 
…rmatter

Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Merge remote-tracking branch 'upstream/main' into feature/flipt-clien…
dfb13ee 
…t-for-dotnet
@jeandreidc
FliptProvider: Updated to throw exceptions instead of handling them a…
a5ed946 
…nd returning ResolutionDetails

Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
FliptProvider: Moved client class generation and referencing in build…
81b5162 
…time, kept openapi.yaml in the solution

Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
FliptProvider: Made constructor that receives a dependent interface i…
128c142 
…nternal

Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
FliptProvider: Updated component_owners
05944bf 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Update readme
d491ef3 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Merge remote-tracking branch 'upstream/main' into feature/flipt-clien…
d17d2d8 
…t-for-dotnet
@jeandreidc
Reverted unintended lint changes to Flagsmith.csproj
2110460 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Fixed Nswag build time error, updated README, removed openapi.yaml cu…
062445a 
…rl command from build events

Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
lint changes in test
14a2223 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Merge remote-tracking branch 'upstream/main' into feature/flipt-clien…
3224b95 
…t-for-dotnet
@jeandreidc
Updated System.Text.Json to latest version
582a4fb 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Changed prebuild stage of nswag generation script
09dbc34 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Use nswag msbuild variables in creating clients
632210b 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Fix System.Http reference in tests
92be761 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Fix import errors on dotnet version 462
06584f7 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Fix failing unit test caused by lint
6a1f64c 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
lint
5312d53 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Fix warnings regarding unused theory params in xunit
37e35af 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc
Merge remote-tracking branch 'upstream/main' into fix/flipt-provider-…
eab1dd4 
…remove-unused-parameters-in-tests
@jeandreidc
lint
ed51049 
Signed-off-by: Andrei de la Cruz <[email protected]>
@jeandreidc jeandreidc requested review from a team as code owners October 18, 2024 09:03
@jeandreidc jeandreidc closed this Oct 18, 2024
@jeandreidc jeandreidc deleted the fix/flipt-provider-remove-unused-parameters-in-tests branch October 18, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release Failed
1 participant
@jeandreidc