feat: Introduce flipt provider for dotnet #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeandreidc
force-pushed
the
feature/flipt-client-for-dotnet
branch
3 times, most recently
from
a116bd7 to
76d160e
Compare
jeandreidc
changed the title
Signed-off-by: Andrei de la Cruz <[email protected]>
Signed-off-by: Andrei de la Cruz <[email protected]>
…dded handling of http exceptions thrown by flipt client Signed-off-by: Andrei de la Cruz <[email protected]>
Signed-off-by: Andrei de la Cruz <[email protected]>
…per serialization to Dict<string, string> Signed-off-by: Andrei de la Cruz <[email protected]>
…JSON settings Signed-off-by: Andrei de la Cruz <[email protected]>
Signed-off-by: Andrei de la Cruz <[email protected]>
Signed-off-by: Andrei de la Cruz <[email protected]>
Signed-off-by: Andrei de la Cruz <[email protected]>
Signed-off-by: Andrei de la Cruz <[email protected]>
Signed-off-by: Andrei de la Cruz <[email protected]>
Signed-off-by: Andrei de la Cruz <[email protected]>
Signed-off-by: Andrei de la Cruz <[email protected]>
…oleans Signed-off-by: Andrei de la Cruz <[email protected]>
…riant types Signed-off-by: Andrei de la Cruz <[email protected]>
jeandreidc
force-pushed
the
feature/flipt-client-for-dotnet
branch
from
722be51 to
10b1d86
Compare
Signed-off-by: Andrei de la Cruz <[email protected]>
jeandreidc
force-pushed
the
feature/flipt-client-for-dotnet
branch
from
478ac9b to
d8d382d
Compare
…spec Signed-off-by: Andrei de la Cruz <[email protected]>
Signed-off-by: Andrei de la Cruz <[email protected]>
…time, kept openapi.yaml in the solution Signed-off-by: Andrei de la Cruz <[email protected]>
…nternal Signed-off-by: Andrei de la Cruz <[email protected]>
Signed-off-by: Andrei de la Cruz <[email protected]>
jeandreidc
force-pushed
the
feature/flipt-client-for-dotnet
branch
from
b4d0564 to
05944bf
Compare
Signed-off-by: Andrei de la Cruz <[email protected]>
|
Thanks again @jeandreidc !! Looks great! cc @toddbaert |
beeme1mr
reviewed
Oct 9, 2024
src/OpenFeature.Contrib.Providers.Flagsmith/OpenFeature.Contrib.Providers.Flagsmith.csproj
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrei de la Cruz <[email protected]>
…rl command from build events Signed-off-by: Andrei de la Cruz <[email protected]>
Signed-off-by: Andrei de la Cruz <[email protected]>
Signed-off-by: Andrei de la Cruz <[email protected]>
|
@beeme1mr @toddbaert is there anything else blocking this from merge? Thanks again @jeandreidc !! |
beeme1mr
approved these changes
Oct 14, 2024
|
Approved, but there's an issue with the build. Feel free to ping me so I can retrigger CI once the issue has been addressed. |
Signed-off-by: Andrei de la Cruz <[email protected]>
|
Fixed the build issue please re-run the workflows, TIA! @beeme1mr |
|
Hello @beeme1mr was it merged by mistake? I was waiting for the build pipeline to pass |
|
Yes, I thought the tests passed but apparently they hadn't started. |
|
@jeandreidc sorry about that. We're going to revert the merge. Could you please open a new PR referencing this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flipt.io provider for dotnet
Initial version of flipt.io provider for dotnet.
Related Issues
None
Notes
Follow-up Tasks
FliptProvider.csclass