feat!: use (and require) OpenFeature SDK v2 #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <[email protected]>
github-actions
bot
assigned adams85, askpt, bacherfl, ericpattison, jenshenneberg, luizbon, matthewelwell, thomaspoignant, toddbaert and vpetrusevici
toddbaert
changed the title
toddbaert
commented
Aug 21, 2024
Comment on lines
-88
to
-93
| /// <inheritdoc/> | ||
| public override ProviderStatus GetStatus() | ||
| { | ||
| return _status; | ||
| } | ||
|
|
There was a problem hiding this comment.
No longer needed (and e2e tests still pass) so everything is working as expected.
toddbaert
commented
Aug 21, 2024
Comment on lines
-104
to
-106
| public override ProviderStatus GetStatus() | ||
| public override async Task InitializeAsync(EvaluationContext context, CancellationToken cancellationToken = default) | ||
| { | ||
| return initialized ? ProviderStatus.Ready : ProviderStatus.NotReady; |
toddbaert
commented
Aug 21, 2024
| { | ||
| return initialized ? ProviderStatus.Ready : ProviderStatus.NotReady; | ||
| await ServerDriver.Initialize(); |
There was a problem hiding this comment.
Now we just need to await this, no need to update any state.
toddbaert
commented
Aug 21, 2024
| @@ -65,7 +65,7 @@ public async Task GetValue_ForEnabledFeatureWithEvaluationContext_ReturnCorrectV | |||
| var date = DateTime.Now; | |||
| flags.GetFeatureValue("example-feature").Returns("true"); | |||
| flags.IsFeatureEnabled("example-feature").Returns(true); | |||
| flagsmithClient.GetIdentityFlags("233", Arg.Is<List<ITrait>>(x => x.Count == 6 && x.Any(c => c.GetTraitKey() == "key1"))).Returns(flags); | |||
| flagsmithClient.GetIdentityFlags("233", Arg.Is<List<ITrait>>(x => x.Count > 6 && x.Any(c => c.GetTraitKey() == "key1"))).Returns(flags); | |||
There was a problem hiding this comment.
This is perhaps the only slightly surprising change here. We include the targeting key in the props now, which makes the count here 1 larger than before.
toddbaert
commented
Aug 21, 2024
| <!-- 1.5-1.9999 --> | ||
| <OpenFeatureVer>[1.5,2.0)</OpenFeatureVer> | ||
| <!-- 2.0-2.9999 --> | ||
| <OpenFeatureVer>[2.0,3.0)</OpenFeatureVer> |
There was a problem hiding this comment.
I've set this to only major version 2 up to 3 (exclusive).
thomaspoignant
approved these changes
Aug 22, 2024
beeme1mr
approved these changes
Aug 22, 2024
luizbon
reviewed
Aug 22, 2024
| { | ||
| return ResolveFlag(flagKey, context, defaultValue); | ||
| } | ||
|
|
||
| /// <inheritdoc/> | ||
| public override async Task<ResolutionDetails<Value>> ResolveStructureValue(string flagKey, Value defaultValue, EvaluationContext context = null) | ||
| public override async Task<ResolutionDetails<Value>> ResolveStructureValueAsync(string flagKey, Value defaultValue, EvaluationContext context = null, CancellationToken cancellationToken = default) |
There was a problem hiding this comment.
Since the CancellationToken is captured, we should pass it down to the GetValueDetailsAsync method.
There was a problem hiding this comment.
I didn't want to really make any functional changes here, but this was a very easy one since the ConfigCat SDK already accepted a cancellation token, so I've done this.
jenshenneberg
approved these changes
Aug 22, 2024
Signed-off-by: Todd Baert <[email protected]>
askpt
approved these changes
Aug 22, 2024
This was referenced Aug 22, 2024
This was referenced Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the entire monorepo to use the 2.0+ version of the SDK, and for all the artifacts to require it.
There was no substantial changes besides the expected method renames, etc.