Fix Flagsmith provider no key exception

Signed-off-by: Vladimir Petrusevici <[email protected]>
open-feature · Nov 8, 2023 · b6a2732 · b6a2732
1 parent 49efdde
commit b6a2732
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/OpenFeature.Contrib.Providers.Flagsmith/FlagsmithProvider.cs b/src/OpenFeature.Contrib.Providers.Flagsmith/FlagsmithProvider.cs
@@ -65,8 +65,13 @@ public FlagsmithProvider(IFlagsmithProviderConfiguration providerOptions, IFlags
 
         private Task<IFlags> GetFlags(EvaluationContext ctx)
         {
-            var key = ctx?.GetValue(Configuration.TargetingKey)?.AsString;
-            return string.IsNullOrEmpty(key)
+            string key = null;
+            if(ctx != null && ctx.TryGetValue(Configuration.TargetingKey, out var value))
+            {
+                key = value?.AsString;
+            }
+
+            return  string.IsNullOrEmpty(key)
                 ? _flagsmithClient.GetEnvironmentFlags()
                 : _flagsmithClient.GetIdentityFlags(key, ctx.AsDictionary().Select(x => new Trait(x.Key, x.Value.AsObject) as ITrait).ToList());
         }

diff --git a/src/OpenFeature.Contrib.Providers.Flagsmith/OpenFeature.Contrib.Providers.Flagsmith.csproj b/src/OpenFeature.Contrib.Providers.Flagsmith/OpenFeature.Contrib.Providers.Flagsmith.csproj
@@ -3,7 +3,7 @@
   <PropertyGroup>
     <TargetFrameworks>netstandard20</TargetFrameworks>
     <PackageId>OpenFeature.Contrib.Providers.Flagsmith</PackageId>
-    <VersionNumber>0.1.0</VersionNumber>
+    <VersionNumber>0.1.1</VersionNumber>
     <!--x-release-please-version -->
     <Version>$(VersionNumber)</Version>
     <AssemblyVersion>$(VersionNumber)</AssemblyVersion>