add tests. handle parse error

open-feature · Oct 18, 2023 · 0404614 · 0404614
1 parent 1a355ab
commit 0404614
Show file tree

Hide file tree

Showing 2 changed files with 381 additions and 12 deletions.
diff --git a/src/OpenFeature.Contrib.Providers.Flagsmith/FlagsmithProvider.cs b/src/OpenFeature.Contrib.Providers.Flagsmith/FlagsmithProvider.cs
@@ -1,6 +1,4 @@
 using Flagsmith;
-using Newtonsoft.Json;
-using Newtonsoft.Json.Linq;
 using OpenFeature.Constant;
 using OpenFeature.Model;
 using System.Collections.Generic;
@@ -49,9 +47,9 @@ public FlagsmithProvider(IFlagsmithClient flagsmithClient)
             _flagsmithClient = flagsmithClient;
         }
 
-        private Task<IFlags> GetFlags(EvaluationContext ctx)
+        private Task<IFlags> GetFlags(EvaluationContext ctx = null)
         {
-            var key = ctx.GetValue("targetingKey").AsString;
+            var key = ctx?.GetValue("targetingKey")?.AsString;
             return string.IsNullOrEmpty(key)
                 ? _flagsmithClient.GetEnvironmentFlags()
                 : _flagsmithClient.GetIdentityFlags(key, ctx.AsDictionary().Select(x => new Trait(x.Key, x.Value.AsObject) as ITrait).ToList());
@@ -148,13 +146,22 @@ public override async Task<ResolutionDetails<Value>> ResolveStructureValue(strin
             }
             var stringValue = await flags.GetFeatureValue(flagKey);
 
-            var mappedValue = JsonNode.Parse(stringValue);
-            var value = ConvertValue(mappedValue);
-            if (value is null)
+            try
             {
-                return new ResolutionDetails<Value>(flagKey, defaultValue, ErrorType.ParseError, Reason.Error, errorMessage: "Failed to parse value in structure type or value is null");
+                var mappedValue = JsonNode.Parse(stringValue);
+                var value = ConvertValue(mappedValue);
+                if (value is not null)
+                {
+                    return new ResolutionDetails<Value>(flagKey, value);
+
+                }
             }
-            return new ResolutionDetails<Value>(flagKey, value);
+            catch
+            {
+
+            }
+            return new ResolutionDetails<Value>(flagKey, defaultValue, ErrorType.ParseError, Reason.Error, errorMessage: "Failed to parse value in structure type or value is null");
+
         }
 
         /// <summary>