Skip to content

Conversation

bparks13
Copy link
Member

Skip the probe contour if it does not exist in the file, as it is not a required element in the ProbeInterface specification.

Add warnings to alert the user about any specific issues found when parsing the file.

@bparks13 bparks13 added this to the 0.1.1 milestone Jul 24, 2025
@bparks13 bparks13 requested a review from jonnew July 24, 2025 15:24
@bparks13 bparks13 self-assigned this Jul 24, 2025
@bparks13 bparks13 requested a review from cjsha July 29, 2025 18:16
@cjsha
Copy link
Collaborator

cjsha commented Jul 29, 2025

The onebox -> onix-source compatibility seems good to me

probeinterface_from-onebox_to-onixsource_sucessful

@cjsha
Copy link
Collaborator

cjsha commented Jul 29, 2025

bonsai -> onix-source compatibility seems good
probeinterface_from-bonsai_to-onixsource_sucessful

@cjsha
Copy link
Collaborator

cjsha commented Jul 29, 2025

onix-source -> bonsai compatibility seems good
probeinterface_from-onixsource_to-bonsai_sucessful

@cjsha
Copy link
Collaborator

cjsha commented Jul 29, 2025

so far so good for np1

@cjsha
Copy link
Collaborator

cjsha commented Jul 29, 2025

Also, there are just a lot of potential ways for the probeinterface file to not correspond to a neuropixels which prompt the user with a warning and i'm not immediately sure how to generate a bunch of probeinterface files to check this logic efficiently

@bparks13
Copy link
Member Author

Also, there are just a lot of potential ways for the probeinterface file to not correspond to a neuropixels which prompt the user with a warning and i'm not immediately sure how to generate a bunch of probeinterface files to check this logic efficiently

@cjsha

I'm not sure if this is the best way to do it, but I would go through and remove or change the necessary elements by hand to trigger the different conditions (i.e., remove the specification field, or change the value in the JSON file), or by loading files that were saved by other devices (such as the Rhs2116 GUI in Bonsai) that had the wrong number of channels.

@jonnew jonnew removed their request for review August 8, 2025 13:29
@bparks13 bparks13 modified the milestones: 0.2.1, 0.3.0, 0.2.0 Aug 8, 2025
@cjsha
Copy link
Collaborator

cjsha commented Aug 13, 2025

bonsai-to-oegui

@cjsha
Copy link
Collaborator

cjsha commented Aug 13, 2025

oegui-to-bonsai

@cjsha
Copy link
Collaborator

cjsha commented Aug 13, 2025

neuropixpxi-to-onix-source

@cjsha
Copy link
Collaborator

cjsha commented Aug 13, 2025

neuropixpxi-to-onix-source

@cjsha
Copy link
Collaborator

cjsha commented Aug 13, 2025

overall i did the following tests:

onix-source bonsai
onix-source n/a np1 & np2
bonsai np1 & np2 n/a
onebox np1 didn't try it
neuropix-pxi np2 didn't try it

probeinterface file was generated by the software in the column and loaded by the software in the row. np1 & np2 indicate which probe was used to perform the probeinterface compatibility test.

onebox and neuropix-pxi don't get their own columns bc they don't have the option to load probeinterface json files.

- The probe_planar_contour is not a required field in the ProbeInterface specification, and as such does not need to exist in the file. Remove the contour if it is not present
@bparks13 bparks13 merged commit f67439a into main Aug 14, 2025
3 checks passed
@bparks13 bparks13 deleted the issue-129 branch August 14, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Probe Interface compatibility
2 participants