-
Notifications
You must be signed in to change notification settings - Fork 1
Update Probe Interface compatibility #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
so far so good for np1 |
Also, there are just a lot of potential ways for the probeinterface file to not correspond to a neuropixels which prompt the user with a warning and i'm not immediately sure how to generate a bunch of probeinterface files to check this logic efficiently |
I'm not sure if this is the best way to do it, but I would go through and remove or change the necessary elements by hand to trigger the different conditions (i.e., remove the |
overall i did the following tests:
probeinterface file was generated by the software in the column and loaded by the software in the row. np1 & np2 indicate which probe was used to perform the probeinterface compatibility test. onebox and neuropix-pxi don't get their own columns bc they don't have the option to load probeinterface json files. |
- The probe_planar_contour is not a required field in the ProbeInterface specification, and as such does not need to exist in the file. Remove the contour if it is not present
Skip the probe contour if it does not exist in the file, as it is not a required element in the ProbeInterface specification.
Add warnings to alert the user about any specific issues found when parsing the file.