Inventory: remove deprecated fields from instance, os and osUpdatePolicy resources #570
+3,323
−5,508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft
3 tasks
3 tasks
jkossak
changed the title
cjnolan
reviewed
Nov 3, 2025
inventory/internal/store/store.go
Outdated
| } | ||
|
|
||
| func setEdgeDesiredOSIDForMut( | ||
| /*func setEdgeDesiredOSIDForMut( |
There was a problem hiding this comment.
If not used anymore, let's remove rather than comment out
There was a problem hiding this comment.
I will clean the commented out code
There was a problem hiding this comment.
Done - removed all redundant code
jkossak
requested review from
Ram-srini,
SushilLakra,
damiankopyto,
ipsita-npg,
krishnajs,
niket-intc,
rranjan3,
soniabha-intc and
sunil-parida
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove earlier deprecated fields from:
Related PR for apiv2: #596
Fixes # (issue)
Any Newly Introduced Dependencies
Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: