Skip to content

feat: deploy local-path-provisioner as an rke2 addon #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

madalazar
Copy link

@madalazar madalazar commented May 29, 2025

Description

Purpose of this PR is to set-up and deploy Rancher Local Path Provisioner as an add-on using RKE2 as a provider. This work is required in i-67996.

Details about the changes

  • My first thought was to store and process the LPP manifest locally mainly to stop any changes being done to it in the future. Instead we not have a lot of Trivy issues. We might need to just pull it in via curl/wget but will wait to see people's opinions on this matter.

  • I'm setting up LPP with similar parameters as I've seen done in K3s (including deploying in the kube-system ns)

  • I was not able to get LPP as an add-on to work with the base extensions with OpenEBS ( I think this is a configuration issue - I tried marking the local-path storageclass as not default and I've moved LPP out into its own namespace but no luck).
    If we want to deploy this CM change separately to base-extension, then the scenario above ^^ requires more debugging to understand. I would start by checking how does the add-on set-up of LPP differ to the base extension deployment used in https://jira.devtools.intel.com/browse/ITEP-27893.

If we are comfortable deploying the changes from CM and ClusterExtensions (open-edge-platform/cluster-extensions#71) at the same time I think the scenario above can be ignored.

Any Newly Introduced Dependencies

No new dependencies were added

How Has This Been Tested?

CO - RKE2 with LPP, base extensions w OpenEBS

  • [Y] cluster successfully deployed
image
  • [N] apps successfully deployed, observability is up, metrics are showing
    I tried marking the local-path storageclass as not default, move the LPP set-up into its own namespace.
image image

CO - RKE2 with LPP, base extensions without openebs

  • [Y]cluster successfully deployed
image
  • apps successfully deployed
image image
  • observability is up, metrics are showing
image image

Checklist:

  • I agree to use the APACHE-2.0 license for my code changes
  • I have not introduced any 3rd party dependency changes
  • I have performed a self-review of my code

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@gcgirish
Copy link
Member

PR open-edge-platform/cluster-connect-gateway#64 needs to merge first.

@gcgirish
Copy link
Member

Lgtm. Couple of questions.

  1. From my understanding of default-cluster-templates/manifests/embed_lpp_manifest.sh, it does not embed the lpp manifest to template if it already exists. Correct? Just checking, because that is what we need
  2. No change for k3s because lpp is part of k3s binary - correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants