-
Notifications
You must be signed in to change notification settings - Fork 0
feat: deploy local-path-provisioner as an rke2 addon #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
madalazar
wants to merge
13
commits into
main
Choose a base branch
from
i-67996
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trivy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
2 tasks
PR open-edge-platform/cluster-connect-gateway#64 needs to merge first. |
Signed-off-by: Lazar, Madalina <[email protected]>
Signed-off-by: Lazar, Madalina <[email protected]>
Signed-off-by: Lazar, Madalina <[email protected]>
Signed-off-by: Lazar, Madalina <[email protected]>
Signed-off-by: Lazar, Madalina <[email protected]>
Signed-off-by: Lazar, Madalina <[email protected]>
Signed-off-by: Lazar, Madalina <[email protected]>
Signed-off-by: Lazar, Madalina <[email protected]>
Signed-off-by: Lazar, Madalina <[email protected]>
Signed-off-by: Lazar, Madalina <[email protected]>
Signed-off-by: Lazar, Madalina <[email protected]>
Signed-off-by: Lazar, Madalina <[email protected]>
Signed-off-by: Lazar, Madalina <[email protected]>
Lgtm. Couple of questions.
|
gcgirish
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Purpose of this PR is to set-up and deploy Rancher Local Path Provisioner as an add-on using RKE2 as a provider. This work is required in i-67996.
Details about the changes
My first thought was to store and process the LPP manifest locally mainly to stop any changes being done to it in the future. Instead we not have a lot of Trivy issues. We might need to just pull it in via curl/wget but will wait to see people's opinions on this matter.
I'm setting up LPP with similar parameters as I've seen done in K3s (including deploying in the kube-system ns)
I was not able to get LPP as an add-on to work with the base extensions with OpenEBS ( I think this is a configuration issue - I tried marking the local-path storageclass as not default and I've moved LPP out into its own namespace but no luck).
If we want to deploy this CM change separately to base-extension, then the scenario above ^^ requires more debugging to understand. I would start by checking how does the add-on set-up of LPP differ to the base extension deployment used in https://jira.devtools.intel.com/browse/ITEP-27893.
If we are comfortable deploying the changes from CM and ClusterExtensions (open-edge-platform/cluster-extensions#71) at the same time I think the scenario above can be ignored.
Any Newly Introduced Dependencies
No new dependencies were added
How Has This Been Tested?
CO - RKE2 with LPP, base extensions w OpenEBS
I tried marking the local-path storageclass as not default, move the LPP set-up into its own namespace.
CO - RKE2 with LPP, base extensions without openebs
Checklist: