Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-86 Fix warning: 'Class is exposed outside of its visibility scope' #87

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

szysas
Copy link
Collaborator

@szysas szysas commented Jul 10, 2024

No description provided.

@szysas szysas self-assigned this Jul 10, 2024
@szysas szysas requested a review from sbernard31 July 10, 2024 18:09
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.11%. Comparing base (7a8e4fb) to head (6802c6a).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #87   +/-   ##
=========================================
  Coverage     93.11%   93.11%           
+ Complexity     1993     1992    -1     
=========================================
  Files           132      132           
  Lines          4505     4505           
  Branches        616      616           
=========================================
  Hits           4195     4195           
  Misses          168      168           
  Partials        142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sbernard31 sbernard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sorry for delay I was unavailable previous weeks)

I didn't test it with revapi but It sounds good to me.

Just here you decide to "change methods visibility to package"
Where in your comment you talked about "changing class visibility to public"

Both are fine to me.

@szysas
Copy link
Collaborator Author

szysas commented Aug 6, 2024

Just here you decide to "change methods visibility to package"
Where in your #86 (comment) you talked about "changing class visibility to public"

Well, that seemed to be smaller fix.

@szysas szysas merged commit 00feadc into master Aug 6, 2024
6 checks passed
@szysas szysas deleted the fix-RawOption-visibility branch August 6, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants