fix

open-coap · Aug 26, 2024 · b914623 · b914623
1 parent b64c1f7
commit b914623
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/coap-core/src/main/java/com/mbed/coap/server/CoapServerBuilder.java b/coap-core/src/main/java/com/mbed/coap/server/CoapServerBuilder.java
@@ -138,10 +138,10 @@ public CoapServerBuilder maxIncomingBlockTransferSize(int size) {
     }
 
     private PutOnlyMap<CoapRequestId, CoapPacket> getOrCreateDuplicateDetectorCache(ScheduledExecutorService scheduledExecutorService) {
-        if (duplicateDetectionCache == null) {
-            duplicateDetectionCache = new DefaultDuplicateDetectorCache("Default cache", duplicationMaxSize, scheduledExecutorService);
+        if (duplicateDetectionCache != null) {
+            return duplicateDetectionCache;
         }
-        return duplicateDetectionCache;
+        return new DefaultDuplicateDetectorCache("Default cache", duplicationMaxSize, scheduledExecutorService);
     }
 
     private CapabilitiesResolver capabilities() {
@@ -208,7 +208,7 @@ public CoapServerBuilder requestTagSupplier(RequestTagSupplier requestTagSupplie
     }
 
     public CoapServer build() {
-        requireNonNull(coapTransport, "Missing transport");
+        CoapTransport coapTransport = requireNonNull(this.coapTransport, "Missing transport");
         final boolean stopExecutor = scheduledExecutorService == null;
         final ScheduledExecutorService effectiveExecutorService = scheduledExecutorService != null ? scheduledExecutorService : Executors.newSingleThreadScheduledExecutor();
         Timer timer = toTimer(effectiveExecutorService);