Fix the PolicyGenerator ArgoCD Policy #464
Conversation
ref: https://issues.redhat.com/browse/ACM-10650 Signed-off-by: Dale Haiducek <[email protected]>
| command: | ||
| - /bin/bash | ||
| image: 'registry.redhat.io/rhacm2/multicluster-operators-subscription-rhel8:v{{ (lookup "operator.open-cluster-management.io/v1" "MultiClusterHub" "open-cluster-management" "multiclusterhub").status.currentVersion }}' | ||
| image: '{{ (index (lookup "apps/v1" "Deployment" "open-cluster-management" "multicluster-operators-hub-subscription").spec.template.spec.containers 0).image }}' |
There was a problem hiding this comment.
Is there a way to make it work if ACM isn't deployed to open-cluster-management namespace?
There was a problem hiding this comment.
Hmmm. Interesting idea--I suppose we could do a lookup using a label on the Deployment. That should only return one result that we can parse...
| @@ -36,15 +36,14 @@ spec: | |||
| initContainers: | |||
| - args: | |||
| - -c | |||
| - cp /etc/kustomize/plugin/policy.open-cluster-management.io/v1/policygenerator/PolicyGenerator | |||
| /policy-generator/PolicyGenerator | |||
| - cp /policy-generator/PolicyGenerator-not-fips-compliant /policy-generator-tmp/PolicyGenerator | |||
There was a problem hiding this comment.
Does the not fips compliant image exist yet?
There was a problem hiding this comment.
Ah, good point. Though we can merge this now and wait to cherry-pick it to 2.10.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 347df6f
into
open-cluster-management-io:main
ref: https://issues.redhat.com/browse/ACM-10650