Make it easier to deploy with argo #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprahl
reviewed
Mar 5, 2024
README.md
Outdated
| @@ -46,6 +46,8 @@ command can be viewed in its [README](deploy/README.md).) This script assumes yo | |||
| Application lifecycle management as an addon in your Open Cluster Management installation. See | |||
| [Application lifecycle management](https://open-cluster-management.io/getting-started/integration/app-lifecycle/) | |||
| for details on installing the Application addon. | |||
| **Note**: If you are using ArgoCD for gitops, a similar script `argoDeploy.sh` is provided that does | |||
| not require the Application lifecycle addon. | |||
There was a problem hiding this comment.
Suggested change
| not require the Application lifecycle addon. | |
| not require the Application Lifecycle addon. |
mprahl
reviewed
Mar 5, 2024
README.md
Outdated
| @@ -46,6 +46,8 @@ command can be viewed in its [README](deploy/README.md).) This script assumes yo | |||
| Application lifecycle management as an addon in your Open Cluster Management installation. See | |||
| [Application lifecycle management](https://open-cluster-management.io/getting-started/integration/app-lifecycle/) | |||
| for details on installing the Application addon. | |||
| **Note**: If you are using ArgoCD for gitops, a similar script `argoDeploy.sh` is provided that does | |||
mprahl
reviewed
Mar 5, 2024
deploy/README.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # Deploy policies to Open Cluster Management | |||
|
|
|||
| Deploy policies to Open Cluster Management with the `deploy.sh` script. | |||
| Deploy policies to Open Cluster Management with the `deploy.sh` script. The `deploy.sh` script uses application lifecycle subscriptions for deployment. To use ArgoCD use the `argoDeploy.sh` script instead. | |||
There was a problem hiding this comment.
Suggested change
| Deploy policies to Open Cluster Management with the `deploy.sh` script. The `deploy.sh` script uses application lifecycle subscriptions for deployment. To use ArgoCD use the `argoDeploy.sh` script instead. | |
| Deploy policies to Open Cluster Management with the `deploy.sh` script. The `deploy.sh` script uses Application Lifecycle subscriptions for deployment. To use ArgoCD use the `argoDeploy.sh` script instead. |
mprahl
previously approved these changes
Mar 5, 2024
|
/hold |
Adding a simple script to help make it easy to deploy policies with argocd. Signed-off-by: Gus Parvin <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gparvin, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 17dad52
into
open-cluster-management-io:main
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a simple script to help make it easy to deploy policies with argocd.