Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove replicationDestination when PVC is bound #454

Conversation

birsanv
Copy link
Contributor

@birsanv birsanv commented Feb 7, 2024

https://issues.redhat.com/browse/ACM-9840

Changes:

  • verify PVC is in Bound state
  • remove the template that verifies the ReplicationDestination status is Successful ( there is a template checking for status Error ; the verification for status is Successful is replaced by the check for the PVC to be Bound )
  • remove ReplicationDestination when the PVC is bound, after the restore operation
Screenshot 2024-02-07 at 1 28 55 PM Screenshot 2024-02-07 at 1 21 38 PM Screenshot 2024-02-07 at 1 36 24 PM

@birsanv
Copy link
Contributor Author

birsanv commented Feb 7, 2024

fyi @tesshuflower

Copy link

openshift-ci bot commented Feb 7, 2024

@birsanv: GitHub didn't allow me to request PR reviews from the following users: tesshuflower.

Note that only open-cluster-management-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @tesshuflower

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@tesshuflower tesshuflower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Feb 7, 2024

@tesshuflower: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: birsanv, gparvin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit aebc9a4 into open-cluster-management-io:main Feb 7, 2024
3 checks passed
@birsanv birsanv deleted the vb_remove_destination_pvcbound branch February 7, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants