Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change path to tests.yml - cleanup after separating pypi and tests #1471

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

AgnieszkaZaba
Copy link
Collaborator

Adressess #1470
I hope it fix it.

@AgnieszkaZaba AgnieszkaZaba requested a review from slayoo December 15, 2024 15:38
@slayoo
Copy link
Member

slayoo commented Dec 15, 2024

It is not related to #1470, but of course worth fixing!
The checksum fixed here is used to trigger cache regeneration for pip package cache in the examples job in CI.

In #1470, the problem is that setuptools_scm stopped taking into account our custom version string setup:

PySDM/setup.py

Line 28 in 4171cfc

use_scm_version={"local_scheme": lambda _: "", "version_scheme": "post-release"},

Without it, the version string contains commit hash, what makes the package wheel names incompatible with PyPI requirements.

@slayoo slayoo merged commit f42ccb9 into main Dec 15, 2024
143 of 149 checks passed
@AgnieszkaZaba AgnieszkaZaba changed the title change path to tests.yml - cleanup after separating pipit and tests change path to tests.yml - cleanup after separating pypi and tests Dec 15, 2024
@AgnieszkaZaba
Copy link
Collaborator Author

Thanks @slayoo!

@AgnieszkaZaba AgnieszkaZaba deleted the AgnieszkaZaba-patch-1 branch December 15, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants