Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix support for breakup in 2D kinematic env example #1436

Open
slayoo opened this issue Nov 24, 2024 · 2 comments
Open

fix support for breakup in 2D kinematic env example #1436

slayoo opened this issue Nov 24, 2024 · 2 comments

Comments

@slayoo
Copy link
Member

slayoo commented Nov 24, 2024

it's a regression introduced in #1371 which was not caught by CI due to lack of test coverage
will break in:
https://github.com/open-atmos/PySDM/blob/main/examples/PySDM_examples/Szumowski_et_al_1998/simulation.py#L115-L116

@AgnieszkaZaba
Copy link
Collaborator

Should we add separate settings file for this example?

@slayoo
Copy link
Member Author

slayoo commented Nov 25, 2024

Yes, I'd say we could try to move the GUI logic out of the Arabas_et_al_2015 example as it has little relevance to the paper.

It would be best to provide a non-GUI notebook in this example that reproduces results close to the paper (i.e., the new settings file), while moving the GUI elsewhere (perhaps to tutorials?) and equipping it with tests covering all conditional cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants