Skip to content

Commit

Permalink
remove unrelated settings from Arabas_et_al_2015 definitions (#1371)
Browse files Browse the repository at this point in the history
  • Loading branch information
slayoo authored Nov 24, 2024
1 parent e19c3e3 commit d3ab146
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions examples/PySDM_examples/Arabas_et_al_2015/settings.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
from typing import Iterable

import numpy as np
from PySDM_examples.Morrison_and_Grabowski_2007.strato_cumulus import StratoCumulus

from PySDM import Formulae
from PySDM.dynamics.collisions.breakup_efficiencies import ConstEb
from PySDM.dynamics.collisions.breakup_fragmentations import Gaussian
from PySDM.dynamics.collisions.coalescence_efficiencies import ConstEc
from PySDM.physics import si


Expand Down Expand Up @@ -39,12 +35,3 @@ def __init__(
self.simulation_time = 90 * si.minute
self.dt = 5 * si.second
self.spin_up_time = 1 * si.hour

# additional breakup dynamics
mu_r = 10 * si.um
mu = 4 / 3 * np.pi * mu_r**3
sigma = mu / 2.5
vmin = mu / 1000
self.coalescence_efficiency = ConstEc(Ec=0.95)
self.breakup_efficiency = ConstEb(Eb=1.0)
self.breakup_fragmentation = Gaussian(mu=mu, sigma=sigma, vmin=vmin, nfmax=10)

1 comment on commit d3ab146

@slayoo
Copy link
Member Author

@slayoo slayoo commented on d3ab146 Nov 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break the code here (which is not covered by tests!): https://github.com/open-atmos/PySDM/blob/main/examples/PySDM_examples/Szumowski_et_al_1998/simulation.py#L115-L116

let's track it in a new issue: #1436

Please sign in to comment.