Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bias Detection Microservice #659

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Add Bias Detection Microservice #659

merged 4 commits into from
Sep 17, 2024

Conversation

qgao007
Copy link
Collaborator

@qgao007 qgao007 commented Sep 10, 2024

Description

Add Bias detection to guard against bias

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • New feature (non-breaking change which adds new functionality)

Dependencies

none.

Tests

● Run the bare deployment through command line, and test the microservice using command line and python script.
● Run the dockerized microservice, and test using command line and python script.

Copy link
Collaborator

@ashahba ashahba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @qgao007 for this PR.

My change request(s) is minor.

Also the new Dockerfile introduced by the PR needs to have an entry at:
.github/workflows/docker/compose/guardrails-compose-cd.yaml

Please let me know if you have any help with that.

Thanks.

comps/guardrails/bias_detection/README.md Outdated Show resolved Hide resolved
comps/guardrails/bias_detection/README.md Outdated Show resolved Hide resolved
@ashahba ashahba added the r1.0 label Sep 10, 2024
@ashahba ashahba added this to the v1.0 milestone Sep 10, 2024
@chensuyue chensuyue removed this from the v1.0 milestone Sep 12, 2024
@lvliang-intel
Copy link
Collaborator

@qgao007,
please fix the pre-commit issue.

image

@qgao007
Copy link
Collaborator Author

qgao007 commented Sep 14, 2024

Thanks @qgao007 for this PR.

My change request(s) is minor.

Also the new Dockerfile introduced by the PR needs to have an entry at: .github/workflows/docker/compose/guardrails-compose-cd.yaml

Please let me know if you have any help with that.

Thanks.

image

@qgao007
Copy link
Collaborator Author

qgao007 commented Sep 14, 2024

@qgao007, please fix the pre-commit issue.

image

Thanks Leon! done.
image

Copy link
Collaborator

@ashahba ashahba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@tybrs tybrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvliang-intel lvliang-intel merged commit 812c85c into main Sep 17, 2024
9 checks passed
@lvliang-intel lvliang-intel deleted the qg/bias branch September 17, 2024 02:01
@@ -0,0 +1,31 @@
# Copyright (C) 2024 Intel Corporation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No e2e test, please add.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants