Split install and cleanup tasks for ACM #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exe-prow-github-app
bot
added
the
approved
bcrochet
force-pushed
the
separate-cleanup
branch
from
ef42bae
to
2037d8e
Compare
This is a PoC for splitting out the install and cleanup tasks. This should be a backward-compatible change. If no role_mode is specified then the default mode is to just run the assessment as it was before. Signed-off-by: Brad P. Crochet <[email protected]>
bcrochet
force-pushed
the
separate-cleanup
branch
from
2037d8e
to
4c1c224
Compare
skattoju
approved these changes
Nov 14, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bcrochet, skattoju The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PoC for splitting out the install and cleanup tasks. This should be a backward-compatible change. If no role_mode is specified then the default mode is to just run the assessment as it was before.