-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scalafmt introduction post work #187
Conversation
We can probably address some concerns from #182 (review) using the |
Not sure from reading the documentation, but isn't exemptScope stronger than excludeRegex? We can still try, it should maybe indent some boolean expressions better, as the default for excludeRegex is && and ||. |
Imo they can be made the same strength:
When "continuation indentation" and "it will be indented" mean the same, setting an impossible regex should just emulate Regardless of how strong it is, imo worth a try. |
Works, but I put it in another PR: #188 |
94dd1d6
to
7f21e49
Compare
Some more changes in the wake of removing Scalariform in favor of Scalafmt