Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): EIP-2537 BLS12-381 Curve Precompile Acceleration #960

Merged
merged 2 commits into from
Jan 29, 2025
Merged

feat(client): EIP-2537 BLS12-381 Curve Precompile Acceleration #960

merged 2 commits into from
Jan 29, 2025

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Jan 28, 2025

Description

Adds support for the EIP-2537 BLS12-381 curve precompile using FPVM acceleration in kona.

Closes #946

@refcell refcell self-assigned this Jan 28, 2025
@refcell refcell requested review from clabby and emhane as code owners January 28, 2025 12:59
@refcell
Copy link
Collaborator Author

refcell commented Jan 28, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

emhane
emhane reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

bin/client/src/precompiles/bls12.rs Outdated Show resolved Hide resolved
@refcell refcell force-pushed the rf/bls12-381-curve branch 2 times, most recently from 205ca07 to 79163b3 Compare January 28, 2025 16:04
@codecov Codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.7%. Comparing base (19eef57) to head (b288bdd).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

emhane
emhane approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

@clabby clabby added the M-blocked meta: blocked label Jan 28, 2025
@refcell refcell force-pushed the rf/bls12-381-curve branch from 91ed66f to b7142de Compare January 28, 2025 21:11
@refcell refcell requested a review from clabby January 28, 2025 21:11
@refcell refcell force-pushed the rf/bls12-381-curve branch from b7142de to 7f61de9 Compare January 28, 2025 21:12
@refcell refcell added K-feature Kind: feature A-client Area: client binary H-isthmus Hardfork: Isthmus related and removed M-blocked meta: blocked labels Jan 28, 2025
clabby
clabby approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Will also want to land this limit in revm.

@refcell
Copy link
Collaborator Author

refcell commented Jan 29, 2025

Nice. Will also want to land this limit in revm.

Will handle this

@refcell refcell merged commit b3ce5ee into main Jan 29, 2025
16 checks passed
@refcell refcell deleted the rf/bls12-381-curve branch January 29, 2025 12:31
@refcell
Copy link
Collaborator Author

refcell commented Jan 29, 2025

Nice. Will also want to land this limit in revm.

Will handle this

bluealloy/revm#2038

byteflyfunny pushed a commit to mantle-xyz/kona that referenced this pull request Feb 13, 2025
@refcell @clabby @byteflyfunny
feat(client): EIP-2537 BLS12-381 Curve Precompile Acceleration (op-rs…
0758a54 
…#960)

Co-authored-by: clabby <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meyer9 meyer9 meyer9 left review comments

@emhane emhane emhane approved these changes

@clabby clabby clabby approved these changes

Assignees

@refcell refcell

Labels
A-client Area: client binary H-isthmus Hardfork: Isthmus related K-feature Kind: feature
Projects
Project Tracking
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(client): Accelerate BLS12-381 precompile
4 participants
@refcell @meyer9 @clabby @emhane