fix(derive): fix bricked arc stage param construction (#84)

op-rs · Apr 4, 2024 · 477051c · 477051c
1 parent 195040b
commit 477051c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/crates/derive/src/stages/channel_bank.rs b/crates/derive/src/stages/channel_bank.rs
@@ -46,8 +46,8 @@ where
     CP: ChainProvider + Debug,
 {
     /// Create a new [ChannelBank] stage.
-    pub fn new(cfg: RollupConfig, prev: FrameQueue<DAP, CP>) -> Self {
-        Self { cfg: Arc::new(cfg), channels: HashMap::new(), channel_queue: VecDeque::new(), prev }
+    pub fn new(cfg: Arc<RollupConfig>, prev: FrameQueue<DAP, CP>) -> Self {
+        Self { cfg, channels: HashMap::new(), channel_queue: VecDeque::new(), prev }
     }
 
     /// Returns the L1 origin [BlockInfo].
@@ -210,7 +210,7 @@ mod tests {
         let dap = TestDAP::default();
         let retrieval = L1Retrieval::new(traversal, dap);
         let frame_queue = FrameQueue::new(retrieval);
-        let mut channel_bank = ChannelBank::new(RollupConfig::default(), frame_queue);
+        let mut channel_bank = ChannelBank::new(Arc::new(RollupConfig::default()), frame_queue);
         let frame = Frame::default();
         let err = channel_bank.ingest_frame(frame).unwrap_err();
         assert_eq!(err, StageError::Custom(anyhow!("No origin")));
@@ -223,7 +223,7 @@ mod tests {
         let dap = TestDAP { results };
         let retrieval = L1Retrieval::new(traversal, dap);
         let frame_queue = FrameQueue::new(retrieval);
-        let mut channel_bank = ChannelBank::new(RollupConfig::default(), frame_queue);
+        let mut channel_bank = ChannelBank::new(Arc::new(RollupConfig::default()), frame_queue);
         let mut frames = new_test_frames(100000);
         // Ingest frames until the channel bank is full and it stops increasing in size
         let mut current_size = 0;
@@ -251,7 +251,7 @@ mod tests {
         let dap = TestDAP { results };
         let retrieval = L1Retrieval::new(traversal, dap);
         let frame_queue = FrameQueue::new(retrieval);
-        let mut channel_bank = ChannelBank::new(RollupConfig::default(), frame_queue);
+        let mut channel_bank = ChannelBank::new(Arc::new(RollupConfig::default()), frame_queue);
         let err = channel_bank.read().unwrap_err();
         assert_eq!(err, StageError::Eof);
         let err = channel_bank.next_data().await.unwrap_err();

diff --git a/crates/derive/src/stages/l1_traversal.rs b/crates/derive/src/stages/l1_traversal.rs
@@ -25,13 +25,13 @@ pub struct L1Traversal<Provider: ChainProvider> {
 
 impl<F: ChainProvider> L1Traversal<F> {
     /// Creates a new [L1Traversal] instance.
-    pub fn new(data_source: F, cfg: RollupConfig) -> Self {
+    pub fn new(data_source: F, cfg: Arc<RollupConfig>) -> Self {
         Self {
             block: Some(BlockInfo::default()),
             data_source,
             done: false,
             system_config: SystemConfig::default(),
-            rollup_config: Arc::new(cfg),
+            rollup_config: cfg,
         }
     }
 
@@ -152,7 +152,7 @@ pub(crate) mod tests {
             let receipts = vec![receipt.clone(), Receipt::default(), receipt];
             provider.insert_receipts(block.hash, receipts);
         }
-        L1Traversal::new(provider, rollup_config)
+        L1Traversal::new(provider, Arc::new(rollup_config))
     }
 
     #[tokio::test]