Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dotnet 6.0 support. #230

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

peymanr34
Copy link
Contributor

@peymanr34 peymanr34 commented Jul 14, 2022

Closes: #222, Closes: #226, Closes: #229

Summary:

  • ImageListView and WPFThumbnailExtractor projects has been migrated to the sdk-style project format.
  • Target frameworks has been set to net35 and net6.0 to stay compatible with older versions of dotnet.
  • The DocumentationFile properties has been replaced with GenerateDocumentationFile property.
  • The CodeAnalysisRuleSet properties has been replaced with .NET Analyzers.

Current issues

  • Packing the library using dotnet pack command fails.
dotnet pack .\ImageListView\ImageListView.csproj -c Release
error : ResGen.exe not supported on .NET Core MSBuild

I think package properties should be moved from ImageListView.nuspec to ImageListView.csproj (or alternatively Directory.Build.props) then pack it via dotnet pack or msbuild -t:pack.

That being said, I'm not exactly sure how to include WPFThumbnailExtractor.dll into the package.

Out of scope

Serving the documentations fails with the following error which can be solved by updating the docfx.console nuget package.

The SDK 'Microsoft.NET.Sdk' specified could not be found.

@peymanr34 peymanr34 marked this pull request as ready for review August 11, 2022 23:51
@peymanr34 peymanr34 changed the title WIP: Add dotnet 6.0 support. Add dotnet 6.0 support. Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET 6 support NU1701 | .Net 5 not compatible Target .NET Standard 2.0 to Support .NET Core Build
1 participant