Oonirun v2.1 #301
Draft
Oonirun v2.1 #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Question: do we want to use headers for this or should we instead make a new post handler which does these in the request body? That would be slightly more flexible if we would like to use this request to pass additional data as part of the first request.
hellais
commented
Feb 18, 2025
sdsantos
reviewed
Apr 16, 2025
| Same as 4.3 GET the OONI Run descriptor | ||
|
|
||
| Note: for dynamically generated run links, this view will only return the | ||
| `target_name` and not the `targets` list. |
There was a problem hiding this comment.
This way, the users never see the full list of URLs to be tested before installing a Run Link right? Maybe on the mobile clients we need to add a button to see the full list on the web...
| ], | ||
|
|
||
| // (optional) string used to specify during creation what is the label for targets to use. | ||
| "targets_name": "websites_list_prioritized", |
There was a problem hiding this comment.
This will come from a fixed list of options right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP specification update for OONI Run v2.1
implements ooni/backend#930