Oonirun v2.1 #301
Merged
Oonirun v2.1 #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Question: do we want to use headers for this or should we instead make a new post handler which does these in the request body? That would be slightly more flexible if we would like to use this request to pass additional data as part of the first request.
hellais
commented
Feb 18, 2025
sdsantos
reviewed
Apr 16, 2025
The concern here is that |
Fix syntax of targets
|
I think I have come up with a better solution to handle older clients in: 6f70178. Basically we don't need to have a new key, but instead we just handle extra metadata for inputs through It also should make the implementation easier and not have to handle multiple different cases depending on client support. |
* Drop targets and replace with `inputs_extra` * Cleanup some text
- Move fields from headers to body - Move fields from query parameters to body - Mark fields for dynamic test lists calculation as required
hellais
commented
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP specification update for OONI Run v2.1
implements ooni/backend#930