add geolookup to ooniapi probe services #1031
Open
+71
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this includes a small refactor to make the probe_geoip method re-usable
LDiazN
reviewed
Nov 4, 2025
ooniapi/services/ooniprobe/src/ooniprobe/routers/v1/probe_services.py
Outdated
Show resolved
Hide resolved
LDiazN
reviewed
Nov 7, 2025
ooniapi/services/ooniprobe/src/ooniprobe/routers/v1/probe_services.py
Outdated
Show resolved
Hide resolved
ooniapi/services/ooniprobe/src/ooniprobe/routers/v1/probe_services.py
Outdated
Show resolved
Hide resolved
ooniapi/services/ooniprobe/src/ooniprobe/routers/v1/probe_services.py
Outdated
Show resolved
Hide resolved
aagbsn
force-pushed
the
add_geolookup_to_ooniapi
branch
from
825c702 to
ba41ff3
Compare
LDiazN
reviewed
Nov 11, 2025
| for ipaddr in data.addresses: | ||
| # call probe_geoip() and map the keys to the geolookup v1 API | ||
| resp, _, _ = probe_geoip(ipaddr, probe_cc, asn, cc_reader, asn_reader) | ||
| # it doesn't seem possible to have separate aliases for (de)serialization |
Contributor
There was a problem hiding this comment.
Does the alias parameter in Field help in any way?
https://docs.pydantic.dev/latest/concepts/fields/#field-aliases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this includes a small refactor to make the probe_geoip method re-usable