Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Formik + hidden screen #3715

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Input Formik + hidden screen #3715

merged 4 commits into from
Jan 20, 2025

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Jan 20, 2025

Description

Fixes https://linear.app/danswer/issue/DAN-1281/knowledge-option-isnt-sticking-around-for

  • Add basic Formik capabilities to new ShadCN components
  • Ensure initial session fetch doesn't mark screen as invisible (wasn't being properly applied and will be more fully addressed in Chat context rework #3713)

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 5:46am

@Weves Weves merged commit f163b79 into main Jan 20, 2025
24 of 26 checks passed
@Weves Weves deleted the formik_shadcn branch January 20, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants