Skip over uninitialized DenseResourceAttrs in verifiers

[jorickert]

Elided elements are uninitialized DenseResourceAttrs.
Without these changes MLIR containing elided DenseResourceAttrs can not be parsed, as the verifiers crash when encountering them.

[AlexandreEichenberger]

Changes make sense. Quick clarification: I see the

if (isElementAttrUninitializedDenseResource(entries)) {
       return success(); // Return success to allow the parsing of MLIR with
                         // elided attributes
     }

in a few places. Is it exhaustive? Or is it where you needed it for a particular test.

Trying to understand the scope of this PR. Thanks

[jorickert]

I do not think that is is exhaustive. I observed one crash in a downstream test in the verifier and did a quick search for .getValues<IntegerAttr>() in the verifiers to find other occurrences. IMO it is likely that there are more code paths in the verifier that do not handle elided attributes

[AlexandreEichenberger]

Thanks for the assessment. Will apply the suggested code on a need-to basis. If you encounter places where this might happen, feel free to update it too.

LGTM

[jorickert]

@AlexandreEichenberger Hello, could you please clarify what you mean with Will apply the suggested code on a need-to basis ? Is it okay to merge this PR or do you plan to cherry-pick parts of it?

[AlexandreEichenberger]

@jorickert Its all good, just saying that if we encounter similar situations in the future, we can look at this PR and your solution on how to quickly fix it. Please merge.

[jenkins-droid]

Jenkins Linux ppc64le Build #15141 [push] Skip over uninitialized ... started at 13:31

[jenkins-droid]

Jenkins Linux s390x Build #16114 [push] Skip over uninitialized ... started at 13:13

[jenkins-droid]

Jenkins Linux amd64 Build #16113 [push] Skip over uninitialized ... started at 12:14

[jenkins-droid]

Jenkins Linux amd64 Build #16113 [push] Skip over uninitialized ... passed after 1 hr 24 min

[jenkins-droid]

Jenkins Linux s390x Build #16114 [push] Skip over uninitialized ... passed after 1 hr 25 min

[jenkins-droid]

Jenkins Linux ppc64le Build #15141 [push] Skip over uninitialized ... passed after 2 hr 23 min