Merge from repo #3033
Merged
Merge from repo #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
| @@ -1,7 +1,12 @@ | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| function(setup_zdnn version) | |||
| set(ZDNN_GITHUB_URL https://github.com/IBM/zDNN) | |||
| # Set policy CMP0097 to NEW for it to not initialize submodules | |||
| cmake_policy(SET CMP0097 NEW) | |||
There was a problem hiding this comment.
This was not in the onnx-mlir/main branch, inherited from other repo. I cannot tell if it is needed or not.
| return ZDNN_INVALID_TYPE; | ||
| } | ||
|
|
||
| const uint32_t *dims_ptr = &(tfrmd_desc->dim4); | ||
|
|
||
| /* ToFix: the nnpa_query_result is not set up with onnx-mlir | ||
| * Temporarily commented out. | ||
| * Refer to issue #288 |
There was a problem hiding this comment.
issue 288 from incoming repo
| @@ -12,6 +17,7 @@ function(setup_zdnn version) | |||
| ExternalProject_Add(zdnn | |||
| GIT_REPOSITORY ${ZDNN_GITHUB_URL} | |||
| GIT_TAG ${version} | |||
| GIT_SUBMODULES "" | |||
There was a problem hiding this comment.
same here, not in onnx-mlir/main branch (as well as online 64 below)
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
tungld
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
LGTM!
When you merge the PR, could you add all co-authors who contributed the code so that they gets attribution in the contribution graph? It seems one way is adding multiple lines of "Co-authored-by: Fullname email@address" to the merging message. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that moves some of the latest work that we did in private repos in the open, with very few relevant changes to non IBM-specific machines.