Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update llvm-project to llvm/llvm-project@af20aff35ec3 #3032

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Update llvm-project to llvm/llvm-project@af20aff35ec3 #3032

merged 5 commits into from
Dec 20, 2024

Conversation

hamptonm1
Copy link
Collaborator

LLVM Commit: af20aff35ec3
StableHLO Commit: 54dafb1c41

@hamptonm1 hamptonm1 self-assigned this Dec 19, 2024
@hamptonm1
Copy link
Collaborator Author

FYI- @AlexandreEichenberger I upgraded to the latest version of LLVM/ StableHLO. So we should be up to speed now :)

@hamptonm1 hamptonm1 marked this pull request as ready for review December 19, 2024 23:11
AlexandreEichenberger
AlexandreEichenberger reviewed Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. I think the old commit string shows up in a few more places, do you mind updating it there too

image

@hamptonm1
Copy link
Collaborator Author

Fantastic. I think the old commit string shows up in a few more places, do you mind updating it there too

image

@AlexandreEichenberger It is updated :)

hamptonm1
hamptonm1 commented Dec 20, 2024
View reviewed changes
utils/clone-mlir.sh
@@ -1,3 +1,3 @@
git clone -n https://github.com/llvm/llvm-project.git
# Check out a specific branch that is known to work with ONNX-MLIR.
cd llvm-project && git checkout 01d233ff403823389f8480897e41aea84ecbb3d3 && cd ..
cd llvm-project && git checkout af20aff35ec37ead88903bc3e44f6a81c5c9ca4e && cd ..
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexandreEichenberger Check here please

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I see it now :-)

AlexandreEichenberger
AlexandreEichenberger approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating to the latest, much appreciated

@AlexandreEichenberger AlexandreEichenberger merged commit f6d0806 into onnx:main Dec 20, 2024
7 checks passed
@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #16086 [push] Update llvm-project to l... started at 10:24

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #16085 [push] Update llvm-project to l... started at 09:25

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #15114 [push] Update llvm-project to l... started at 10:41

@hamptonm1 hamptonm1 deleted the hamptonm/feature/llvm-plus branch December 20, 2024 15:27
@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #16086 [push] Update llvm-project to l... passed after 2 hr 57 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #16085 [push] Update llvm-project to l... passed after 2 hr 58 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #15114 [push] Update llvm-project to l... passed after 4 hr 9 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreEichenberger AlexandreEichenberger AlexandreEichenberger approved these changes

Assignees

@hamptonm1 hamptonm1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hamptonm1 @jenkins-droid @AlexandreEichenberger @MegoHam21