Do not fuse locations when normalizing constants for Add and Mul #3016
+34
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rickert, Jonas <[email protected]>
|
@jenkins-droid test this please |
AlexandreEichenberger
approved these changes
Nov 22, 2024
|
@AlexandreEichenberger Could you take a look at the CI please? It seems to be stuck. |
|
@jorickert The Jenkins machines are under maintenance and they are expected to be back soon this week. We will merge this PR and others as soon as the machines are available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR, the location of the Add/Mul will be incorrectly fused with the location of the constant.