Release MLIRContext and Module before executing opt command for memory reduction #3000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haruki Imai <[email protected]> Co-authored-by: Yasushi Negishi <[email protected]>
tungld
reviewed
Nov 6, 2024
| // Free memory before using LLVM `opt` command | ||
| llvmModule.reset(); | ||
| module.release(); | ||
| context.~MLIRContext(); |
There was a problem hiding this comment.
Do you know what are freed/released with these statements? It looks not too much memory saved and not sure it is worth to make a change.
tungld
reviewed
Nov 6, 2024
| @@ -598,10 +604,12 @@ static int genJniJar(const mlir::OwningOpRef<ModuleOp> &module, | |||
| } | |||
|
|
|||
| // Return 0 on success, error code on failure | |||
| static int compileModuleToObject(const mlir::OwningOpRef<ModuleOp> &module, | |||
| std::string outputNameWithoutExt, std::string &objectNameWithExt) { | |||
| static int compileModuleToObject(mlir::OwningOpRef<ModuleOp> &module, | |||
There was a problem hiding this comment.
Removing const and freeing the object internally seems difficult to follow, at least by looking at the function name. Same for other signature changes in other functions.
Signed-off-by: Haruki Imai <[email protected]>
tungld
reviewed
Nov 8, 2024
| @@ -806,7 +819,7 @@ static int emitOutputFiles(std::string outputNameNoExt, | |||
| case EmitLib: { | |||
| std::string sharedLibNameWithExt; | |||
| int rc = compileModuleToSharedLibrary( | |||
| module, outputNameNoExt, sharedLibNameWithExt); | |||
| module, outputNameNoExt, sharedLibNameWithExt, context); | |||
There was a problem hiding this comment.
@imaihal just be noticed that module and context are potentially used later by outputCode (See Line 813/826). So please make sure outputCode still works since module has been released inside compileModuleToSharedLibrary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR releases MLIRContext and Module before execution opt command. They are not necessary after writing LLVM bitcode. By releasing the module, the peak memory reduced a bit.